Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test headers #185

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Feature/test headers #185

merged 3 commits into from
Aug 21, 2024

Conversation

AbigailDeng
Copy link
Collaborator

No description provided.

Copy link

vizipi bot commented Aug 20, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
93.41% aelf-lxy 5 85
16.48% 轩辕焮痕 13 15
8.79% lhoopox 5 8
4.40% Alef-hz 7 4
4.40% RutvikGhaskataEalf 1 4
1.10% Rutvik 1 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 89.88%[types/util/httpProvider.d.ts]
  • 95.71%[types/chain/index.d.ts]
  • 91.41%[types/util/proto.d.ts]
  • 99.69%[package.json]
  • 66.56%[.github/workflows/coverage.yml]
  • 70.55%[proto/transaction_fee.proto.json]
  • 57.36%[.github/workflows/test-badge.yml]
  • 85.28%[test/unit/chain/chainMethod.test.js]
  • 76.99%[src/util/merkleTree.js]
  • 79.45%[test/unit/util/formatter.test.js]
  • Copy link

    🔴 Total coverage is lower than the default branch

    Lines Branches Functions Statements
    99.04% (-0.37%) 97.54% (-1.31%) 99.07% (+0.05%) 99.08% (-0.36%)

    Detailed report

    click to open the diff coverage report
    File Lines Branches Functions Statements
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/chainMethod.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/contractMethod.js 99.31% (+99.31%) 95.45% (+95.45%) 100.00% (+100.00%) 99.33% (+99.33%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/bloom.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/errors.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/formatters.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/httpProvider.js 93.16% (+93.16%) 89.85% (+89.85%) 92.00% (+92.00%) 93.27% (+93.27%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keccak.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keyStore.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/merkleTree.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/proto.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/requestManage.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/settings.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/sha256.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/transform.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/utils.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/wallet/index.js 100.00% (+100.00%) 90.90% (+90.90%) 100.00% (+100.00%) 100.00% (+100.00%)

    @AbigailDeng AbigailDeng linked an issue Aug 20, 2024 that may be closed by this pull request
    3 tasks
    @hzz780 hzz780 merged commit a921109 into feature/test-chain-util Aug 21, 2024
    2 of 3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    aelf-web3.js - headers fix
    2 participants