Skip to content

Commit

Permalink
Remove deprecated Frame functionality for v1.0 (#557)
Browse files Browse the repository at this point in the history
* Remove deprecated Frame property from python bindings

* Remove deprecated function from Frame interface

* Remove unused import
  • Loading branch information
tmadlener authored Feb 13, 2024
1 parent 6fbd1b2 commit 578bfee
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
8 changes: 0 additions & 8 deletions include/podio/Frame.h
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,6 @@ class Frame {

// Interfaces for writing below
// TODO: Hide this from the public interface somehow?

/**
* Get the GenericParameters for writing
*/
[[deprecated("use getParameters instead")]] const podio::GenericParameters& getGenericParametersForWrite() const {
return m_self->parameters();
}

/**
* Get a collection for writing (in a prepared and "ready-to-write" state)
*/
Expand Down
15 changes: 0 additions & 15 deletions python/podio/frame.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/usr/bin/env python3
"""Module for the python bindings of the podio::Frame"""

import warnings
import cppyy

import ROOT
Expand Down Expand Up @@ -119,20 +118,6 @@ def getAvailableCollections(self):
"""
return tuple(str(s) for s in self._frame.getAvailableCollections())

@property
def collections(self):
"""Get the currently available collection (names) from this Frame.
Returns:
tuple(str): The names of the available collections from this Frame.
"""
warnings.warn(
"WARNING: collections is deprecated, use getAvailableCollections()"
" (like in C++) instead",
FutureWarning,
)
return self.getAvailableCollections()

def get(self, name):
"""Get a collection from the Frame by name.
Expand Down

0 comments on commit 578bfee

Please sign in to comment.