Make sure to set valid and collectionID for all links (#732)

Feature parity with other collections
AIDASoft · Feb 4, 2025 · c9f1d04 · c9f1d04
1 parent cfaaa7e
commit c9f1d04
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/include/podio/detail/LinkCollectionImpl.h b/include/podio/detail/LinkCollectionImpl.h
@@ -210,6 +210,10 @@ class LinkCollection : public podio::CollectionBase {
 
   void setID(unsigned id) override {
     m_collectionID = id;
+    if (!m_isSubsetColl) {
+      std::ranges::for_each(m_storage.entries, [id](auto* obj) { obj->id = {obj->id.index, id}; });
+    }
+    m_isValid = true;
   }
 
   unsigned getID() const override {

diff --git a/tests/unittests/links.cpp b/tests/unittests/links.cpp
@@ -318,6 +318,15 @@ TEST_CASE("LinkCollection subset collection", "[links][subset-colls]") {
 TEST_CASE("LinkCollection basics", "[links]") {
   REQUIRE(podio::detail::linkCollTypeName<ExampleCluster, ExampleHit>() ==
           "podio::LinkCollection<ExampleCluster,ExampleHit>");
+
+  auto links = TestLColl{};
+  auto link = links.create();
+  REQUIRE(link.id().collectionID == 0);
+
+  links.setID(42);
+  for (auto l : links) {
+    REQUIRE(l.id().collectionID == 42);
+  }
 }
 
 auto createLinkCollections(const size_t nElements = 3u) {