Skip to content

Commit

Permalink
Mark the collection destructor with override and remove an array incl…
Browse files Browse the repository at this point in the history
…ude (#716)

Co-authored-by: jmcarcell <[email protected]>
  • Loading branch information
jmcarcell and jmcarcell authored Dec 9, 2024
1 parent 98a15af commit f6662ad
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions python/templates/Collection.h.jinja2
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

#include <string_view>
#include <vector>
#include <array>
#include <algorithm>
#include <ostream>
#include <mutex>
Expand Down Expand Up @@ -60,7 +59,7 @@ public:
{{ class.bare_type }}Collection& operator=({{ class.bare_type }}Collection&&) = default;

// {{ class.bare_type }}Collection({{ class.bare_type }}Vector* data, uint32_t collectionID);
~{{ class.bare_type }}Collection();
~{{ class.bare_type }}Collection() override;

constexpr static auto typeName = "{{ (class | string ).strip(':') + "Collection" }}";
constexpr static auto valueTypeName = "{{ (class | string ).strip(':') }}";
Expand Down

0 comments on commit f6662ad

Please sign in to comment.