Fix the pre-commit workflow #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. Waiting to see what the test will say :-) |
|
@tmadlener - I assume it only takes effect after merging :-( |
|
No, it should take into account the state of this branch. I am not entirely sure why |
|
OK. Now everything should work. Let's see if CI agrees. |
4 tasks
|
thanks! |
hegner
pushed a commit
to hegner/podio
that referenced
this pull request
Jul 27, 2023
* Switch to a newer LCG stack with root 6.28/00 * Try with key4hep nightlies * Allow git to run necessary commands for pre-commit * Fix clang-format complaints * Fix clang-tidy complaints * Reorder some imports to make pylint happy again * Enbale building RNTuple support in more workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
pre-commitworkflow by making it run on top of the key4hep nightlies that come with a recent enough root version to be able to work with the RNTuple addition (Add support for the new RNTuple format #395)clang-format,clang-tidyandpylintENDRELEASENOTES