Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated EventStore based I/O functionality #485

Merged
merged 37 commits into from
Dec 13, 2023
Merged

Remove deprecated EventStore based I/O functionality #485

merged 37 commits into from
Dec 13, 2023

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Sep 15, 2023 •
edited
Loading

BEGINRELEASENOTES

ENDRELEASENOTES

This is currently only the first steps to remove the EventStore based I/O functionality (as outlined in #429). It is quite far from complete. The main purpose at this point is to get a feeling of how many things need to be touched in the end. This removes all traces of the EventStore and related readers and writers.

@tmadlener tmadlener linked an issue Sep 15, 2023 that may be closed by this pull request
Removal of deprecated EventStore and related components #429
Closed
@tmadlener tmadlener force-pushed the rm-event-store branch 2 times, most recently from 05fbeee to 57fc758 Compare October 12, 2023 10:37
@tmadlener
Copy link
Collaborator Author

What is left to do here is essentially checking the documentation for remnants of the EventStore but we could also address that in fixing the documentation for version 1.0.

@tmadlener tmadlener changed the title [WIP] Remove deprecated EventStore based I/O functionality Remove deprecated EventStore based I/O functionality Oct 12, 2023
@tmadlener tmadlener force-pushed the rm-event-store branch 4 times, most recently from 8ef2475 to 08decf9 Compare October 12, 2023 15:26
@tmadlener tmadlener mentioned this pull request Oct 12, 2023
Merged
tmadlener
tmadlener commented Oct 13, 2023
View reviewed changes
doc/examples.md Outdated Show resolved Hide resolved
@tmadlener
Copy link
Collaborator Author

Now, I think I got everything EventStore related including documentation.

tmadlener
tmadlener commented Oct 13, 2023
View reviewed changes
doc/examples.md Outdated Show resolved Hide resolved
hegner
hegner approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@hegner hegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to quickly come back to the metadata interface discussion like #407 and #228 before cutting the release. Otherwise fine.
Should we wait for Monday/Tuesday for the merge? We may kill nightlies over weekend otherwise

doc/examples.md
Meta data can be stored and retrieved from the `EventStore` for runs, collections and events via
the three methods:
```cpp
virtual GenericParameters& EventStore::getRunMetaData(int runID);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a small explanation that one just creates a frame if there is a metadata use case? Just to explain a bit more the frame concept

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a non-default one where putting a parameter is not enough

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this in this PR still, or do we push it into the documentation update?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can go to a separate PR

@tmadlener tmadlener mentioned this pull request Nov 8, 2023
Merged
@tmadlener
Copy link
Collaborator Author

Not entirely sure what to make of CI at the moment. Things that fail in CI are working locally, and things that fail locally are failing in CI...

tmadlener
tmadlener commented Dec 13, 2023
View reviewed changes
doc/advanced_topics.md Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@tmadlener tmadlener merged commit 1134a24 into AIDASoft:master Dec 13, 2023
18 checks passed
@tmadlener tmadlener deleted the rm-event-store branch December 13, 2023 09:59
@tmadlener tmadlener mentioned this pull request Dec 15, 2023
Merged
@tmadlener tmadlener mentioned this pull request Feb 12, 2024
Closed
@tmadlener tmadlener mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner hegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of deprecated EventStore and related components
2 participants
@tmadlener @hegner