-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the cmake ExternalData module to manage test data #508
Conversation
It also seems to be quite fast; since it downloads files as cmake targets I think it may be also doing downloads in parallel |
@jmcarcell - what's the compilation problem in the sanitizer? |
I have no idea, there isn't an error message and it seems to be able to build everything. Maybe something transient? Nothing changes for how C++ files are built so it also doesn't make sense that it would fail with this PR. Maybe rerun the workflow? |
Seems to be a connection issue (?): https://github.com/AIDASoft/podio/actions/runs/6712192831/job/18241205323?pr=508#step:4:1075 |
If you click the link now it's fine and in my tests I have not yet seen that problem 🤷 |
Seems to have been transient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks :)
Wait a bit before merging please because I may be able to change a bit how files are named on the EOS side... (so maybe there is a different path at the end) |
Ok I think this is ready. The best we can seem to get is to have symbolic links in the same directory as the files (that is, everything in the same directory):
|
BEGINRELEASENOTES
-DExternalData_OBJECT_STORES=/path/to/store
and it will download the test files there if they are not there but otherwise use them from there, so building from scratch won't download the test files again.ENDRELEASENOTES
The downside is that the test files are now hashes since we have a very simple web server to retrieve them. And there is now a file for each test file with its hash, so changing a file means also the hash should be changed.
I wanted to have a look at this because I didn't like the fact that test files are always downloaded at configuration time and I'm happy now with the local store and will add this to the other key4hep repos with test files.