Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code in GenericParameters.h #706

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Remove unnecessary code in GenericParameters.h #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions include/podio/GenericParameters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,7 @@ using version_type = uint32_t; // from sio/definitions
} // namespace sio
#endif

#if PODIO_ENABLE_RNTUPLE
namespace podio {
class RNTupleReader;
class RNTupleWriter;
} // namespace podio
#endif

namespace podio {

#if !defined(__CLING__)
// cling doesn't really deal well (i.e. at all in this case) with the forward
// declaration here and errors out, breaking e.g. python bindings.
class ROOTReader;
#endif

/// The types which are supported in the GenericParameters
using SupportedGenericDataTypes = std::tuple<int, float, std::string, double>;
Expand Down Expand Up @@ -140,15 +127,6 @@ class GenericParameters {
friend void readGenericParameters(sio::read_device& device, GenericParameters& parameters, sio::version_type version);
#endif

#if PODIO_ENABLE_RNTUPLE
friend RNTupleReader;
friend RNTupleWriter;
#endif

#if !defined(__CLING__)
friend ROOTReader;
#endif

/// Get a reference to the internal map for a given type
template <typename T>
const MapType<detail::GetVectorType<T>>& getMap() const {
Expand Down