Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add requirements.txt #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kommentlezz
Copy link

Great job, team!

I am submitting the requirements.txt file because many have consistently asked for one.

Even though it was trained with PyTorch:1.11.0, it seems to work just fine with 2.2.1.

The entire pipeline has already processed 10 million images with the specified/tested lib versions.

Driver Version: 525.147.05, CUDA Version: 12.1

Let me know if you need any further help!

@onuralpszr
Copy link
Contributor

Project have pyproject.toml file, so we don't need that req.txt. Toml file already has package list.

@kommentlezz
Copy link
Author

People are asking for one.

@onuralpszr
Copy link
Contributor

People are asking for one.

Well, first your install guide and your package list missing, You also installed the latest pytorch what I did was set a minimum version of PyTorch and torchvision. I should ask, "Which problem does this PR solve"? I was the one who removed requirement.txt and setup.py in favor of "pyproject.toml" for a better approach.

@kommentlezz
Copy link
Author

Then the README.md should be updated accordingly, because one is asked to just install the latest torch, wheel while running demo.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants