sonarcloud

AJPfleger · Sep 7, 2024 · 26fe6fd · 26fe6fd
1 parent c24c589
commit 26fe6fd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/Examples/Algorithms/Digitization/src/ModuleClusters.cpp b/Examples/Algorithms/Digitization/src/ModuleClusters.cpp
@@ -136,11 +136,10 @@ void ModuleClusters::merge() {
 
 // ATTN: returns vector of index into `indices'
 std::vector<std::size_t> ModuleClusters::nonGeoEntries(
-    std::vector<Acts::BoundIndices>& indices) {
+    const std::vector<Acts::BoundIndices>& indices) {
   std::vector<std::size_t> retv;
   for (std::size_t i = 0; i < indices.size(); i++) {
-    auto idx = indices.at(i);
-    if (!rangeContainsValue(m_geoIndices, idx)) {
+    if (!rangeContainsValue(m_geoIndices, indices.at(i))) {
       retv.push_back(i);
     }
   }
@@ -223,7 +222,7 @@ std::vector<std::vector<ModuleValue>> ModuleClusters::mergeParameters(
   return retv;
 }
 
-ModuleValue ModuleClusters::squash(std::vector<ModuleValue>& values) {
+ModuleValue ModuleClusters::squash(const std::vector<ModuleValue>& values) {
   ModuleValue mval;
   Acts::ActsScalar tot = 0;
   Acts::ActsScalar tot2 = 0;

diff --git a/Examples/Python/src/Geometry.cpp b/Examples/Python/src/Geometry.cpp
@@ -67,10 +67,9 @@ struct MaterialSurfaceSelector {
 
   /// @param surface is the test surface
   void operator()(const Acts::Surface* surface) {
-    if (surface->surfaceMaterial() != nullptr) {
-      if (!rangeContainsValue(surfaces, surface)) {
-        surfaces.push_back(surface);
-      }
+    if (surface->surfaceMaterial() != nullptr &&
+        !rangeContainsValue(surfaces, surface)) {
+      surfaces.push_back(surface);
     }
   }
 };

diff --git a/Examples/Python/src/Svg.cpp b/Examples/Python/src/Svg.cpp
@@ -69,7 +69,7 @@ actsvg::svg::object viewDetectorVolume(const Svg::ProtoVolume& pVolume,
   svgDet._id = identification;
   svgDet._tag = "g";
 
-  auto [view, selection, viewRange] = viewAndRange;
+  const auto& [view, selection, viewRange] = viewAndRange;
 
   // Translate selection into booleans
   const bool all = rangeContainsValue(selection, "all");

diff --git a/Plugins/Detray/src/DetrayMaterialConverter.cpp b/Plugins/Detray/src/DetrayMaterialConverter.cpp
@@ -27,10 +27,9 @@ struct MaterialSurfaceSelector {
 
   /// @param surface is the test surface
   void operator()(const Acts::Surface* surface) {
-    if (surface->surfaceMaterial() != nullptr) {
-      if (!rangeContainsValue(surfaces, surface)) {
-        surfaces.push_back(surface);
-      }
+    if (surface->surfaceMaterial() != nullptr &&
+        !rangeContainsValue(surfaces, surface)) {
+      surfaces.push_back(surface);
     }
   }
 };