Skip to content

Commit

Permalink
fix: Fix vertexing for physmon ckf tracking (acts-project#2547)
Browse files Browse the repository at this point in the history
`associatedParticles` should not be used after CKF as we cannot guarantee that they will line up with tracks coming from the CKF. this way the writer will try to associate the particles via tracks itself.
  • Loading branch information
andiwand authored Oct 17, 2023
1 parent 89888a4 commit 69e2190
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 9 deletions.
Binary file modified CI/physmon/reference/performance_amvf_truth_estimated_hist.root
Binary file not shown.
Binary file modified CI/physmon/reference/performance_amvf_truth_smeared_hist.root
Binary file not shown.
Binary file modified CI/physmon/reference/performance_ivf_truth_estimated_hist.root
Binary file not shown.
Binary file modified CI/physmon/reference/performance_ivf_truth_smeared_hist.root
Binary file not shown.
7 changes: 0 additions & 7 deletions CI/physmon/workflows/physmon_ckf_tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ def run_ckf_tracking(truthSmearedSeeded, truthEstimatedSeeded, label):
s,
setup.field,
seeder=acts.VertexSeedFinder.GaussianSeeder,
associatedParticles=None
if label in ["seeded", "orthogonal"]
else "particles_input",
outputProtoVertices="ivf_protovertices",
outputVertices="ivf_fittedVertices",
vertexFinder=VertexFinder.Iterative,
Expand All @@ -156,9 +153,6 @@ def run_ckf_tracking(truthSmearedSeeded, truthEstimatedSeeded, label):
s,
setup.field,
seeder=acts.VertexSeedFinder.GaussianSeeder,
associatedParticles=None
if label in ["seeded", "orthogonal"]
else "particles_input",
outputProtoVertices="amvf_protovertices",
outputVertices="amvf_fittedVertices",
vertexFinder=VertexFinder.AMVF,
Expand All @@ -172,7 +166,6 @@ def run_ckf_tracking(truthSmearedSeeded, truthEstimatedSeeded, label):
s,
setup.field,
seeder=acts.VertexSeedFinder.AdaptiveGridSeeder,
associatedParticles=None,
outputProtoVertices="amvf_gridseeder_protovertices",
outputVertices="amvf_gridseeder_fittedVertices",
vertexFinder=VertexFinder.AMVF,
Expand Down
2 changes: 0 additions & 2 deletions CI/physmon/workflows/physmon_track_finding_ttbar.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
s,
setup.field,
seeder=acts.VertexSeedFinder.GaussianSeeder,
associatedParticles=None,
outputProtoVertices="amvf_protovertices",
outputVertices="amvf_fittedVertices",
vertexFinder=VertexFinder.AMVF,
Expand All @@ -172,7 +171,6 @@
s,
setup.field,
seeder=acts.VertexSeedFinder.AdaptiveGridSeeder,
associatedParticles=None,
outputProtoVertices="amvf_gridseeder_protovertices",
outputVertices="amvf_gridseeder_fittedVertices",
vertexFinder=VertexFinder.AMVF,
Expand Down

0 comments on commit 69e2190

Please sign in to comment.