remove copy of ConstVectorMTJ

AJPfleger · Oct 30, 2024 · 84b0ce2 · 84b0ce2
1 parent 1488491
commit 84b0ce2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/Core/include/Acts/EventData/VectorMultiTrajectory.hpp b/Core/include/Acts/EventData/VectorMultiTrajectory.hpp
@@ -522,10 +522,10 @@ class ConstVectorMultiTrajectory final
   ConstVectorMultiTrajectory(const ConstVectorMultiTrajectory& other)
       : VectorMultiTrajectoryBase{other} {}
 
-  ConstVectorMultiTrajectory(const VectorMultiTrajectory& other)
+  explicit ConstVectorMultiTrajectory(const VectorMultiTrajectory& other)
       : VectorMultiTrajectoryBase{other} {}
 
-  ConstVectorMultiTrajectory(VectorMultiTrajectory&& other)
+  explicit ConstVectorMultiTrajectory(VectorMultiTrajectory&& other)
       : VectorMultiTrajectoryBase{std::move(other)} {}
 
   ConstVectorMultiTrajectory(ConstVectorMultiTrajectory&&) = default;

diff --git a/Tests/UnitTests/Core/EventData/MultiTrajectoryTests.cpp b/Tests/UnitTests/Core/EventData/MultiTrajectoryTests.cpp
@@ -91,12 +91,8 @@ BOOST_AUTO_TEST_CASE(ConstCorrectness) {
     // ctsp.predicted().setRandom();
   }
 
-  // is this something we actually want?
-  ConstVectorMultiTrajectory ct = t;
-  BOOST_CHECK_EQUAL(ct.size(), t.size());
-
   ConstVectorMultiTrajectory ctm{std::move(t)};
-  BOOST_CHECK_EQUAL(ctm.size(), ct.size());
+  BOOST_CHECK_EQUAL(ctm.size(), t.size());
 
   {
     static_assert(