Add game running scripts #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was being written to the current working directory, which causes "leakage" with Singularity/Apptainer.
I wrote these scripts to be called directly in the terminal, but now I want to reuse their functionality in other scripts. This required some refactoring. During these substantial changes, I also made some unrelated code quality improvements, such as factoring out magic numbers and improving type checking.
aphedges
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with #194, I made most of these changes around a year ago but never merged them. This PR contains cleaned up versions of them. I have confirmed that they still work for ALLAN, but the ANTONY and CICERO running might be broken.