Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Simplified Chinese localization #16

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add Simplified Chinese localization #16

wants to merge 3 commits into from

Conversation

Hambaka
Copy link

@Hambaka Hambaka commented Sep 24, 2021 •
edited
Loading

This PR is not ready for merge due to several issues:

  • Font issues.
  • Translation issues.

There are two font issues existed, waiting for solution.

  • Font size: The default font size is too small, will result poor readability of Chinese hanzi. But changing font size may also cause other problems.
  • The hanzi/kanji shape conflict among CJK: Many hanzi/kanji share same unicode, but the shape is different in different languages. To show this difference, it really depend on font itself.

Translation issues:

  • Waiting for other Chinese native speaker to look over the translation. Though I think headers pictures are ok.
  • Still need to change some translations after Metroid Dread released, need to refer to part of the new official Chinese translation in M:D. (Revision Completed)

@Miepee Miepee marked this pull request as draft January 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hambaka