Fix Oliveira_NatCommun2021 gradient check

AMICI-dev · Oct 3, 2024 · 153a67c · 153a67c
1 parent fbb74ef
commit 153a67c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/tests/benchmark-models/test_petab_benchmark.py b/tests/benchmark-models/test_petab_benchmark.py
@@ -76,8 +76,9 @@ class GradientCheckSettings:
     rtol_sim=1e-10,
 )
 settings["Oliveira_NatCommun2021"] = GradientCheckSettings(
-    atol_sim=1e-10,
-    rtol_sim=1e-10,
+    # Avoid "root after reinitialization"
+    atol_sim=1e-12,
+    rtol_sim=1e-12,
 )
 settings["Okuonghae_ChaosSolitonsFractals2020"] = GradientCheckSettings(
     atol_sim=1e-14,
@@ -144,6 +145,8 @@ def test_benchmark_gradient(model, scale, sensitivity_method, request):
         model
         in (
             "Blasi_CellSystems2016",
+            # events with parameter-dependent triggers
+            #  https://github.com/AMICI-dev/AMICI/issues/18
             "Oliveira_NatCommun2021",
         )
         and sensitivity_method == SensitivityMethod.adjoint