Skip to content

Commit

Permalink
decrease integration tols
Browse files Browse the repository at this point in the history
  • Loading branch information
FFroehlich committed Dec 18, 2024
1 parent 1f1a66f commit 61d83a7
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions tests/benchmark-models/test_petab_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

from functools import partial
from pathlib import Path

import diffrax
import fiddy
import amici
import numpy as np
Expand Down Expand Up @@ -344,6 +346,15 @@ def test_jax_llh(benchmark_problem):
)
llh_jax, _ = beartype(run_simulations)(jax_problem)
if problem_id in problems_for_gradient_check:
kwargs = {}
if problem_id in ("Brannmark_JBC2010", "Zheng_PNAS2012"):
kwargs["controller"] = diffrax.PIDController(
atol=1e-10,
rtol=1e-10,
pcoeff=0.4,
icoeff=0.3,
dcoeff=0.0,
)
(llh_jax, _), sllh_jax = eqx.filter_value_and_grad(
run_simulations, has_aux=True
)(jax_problem)
Expand Down

0 comments on commit 61d83a7

Please sign in to comment.