Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky python/tests/test_jax.py::test_conversion #2598

Closed
dweindl opened this issue Nov 25, 2024 · 2 comments · Fixed by #2601
Closed

Flaky python/tests/test_jax.py::test_conversion #2598

dweindl opened this issue Nov 25, 2024 · 2 comments · Fixed by #2601
Labels

Comments

@dweindl
Copy link
Member

dweindl commented Nov 25, 2024

https://github.com/AMICI-dev/AMICI/actions/runs/12019272418/job/33505489070:

FAILED python/tests/test_jax.py::test_conversion - AssertionError: 
Not equal to tolerance rtol=1e-05, atol=1e-05
field sllh does not match
Mismatched elements: 1 / 2 (50%)
Max absolute difference among violations: 1.87327994e-05
Max relative difference among violations: 2.20057975e-05
 ACTUAL: array([0.085145, 0.851285])
 DESIRED: array([0.085145, 0.851267])
@dweindl dweindl added the ci label Nov 25, 2024
@FFroehlich
Copy link
Member

Stochasticity probably comes in during generation of synthetic data in the ExpData constructor. We can‘t even set a seed for that, right? Probably best to just set tolerances to 1e-4.

@dweindl
Copy link
Member Author

dweindl commented Nov 26, 2024

Stochasticity probably comes in during generation of synthetic data in the ExpData constructor.

Makes sense.

We can‘t even set a seed for that, right?

True, we might want to change that (#2599).

Probably best to just set tolerances to 1e-4.

Or decrease integration tolerances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants