Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change integration tolerances JAX test #2601

Merged
merged 2 commits into from
Nov 26, 2024
Merged

change integration tolerances JAX test #2601

merged 2 commits into from
Nov 26, 2024

Conversation

FFroehlich
Copy link
Member

fixes #2598, test pass locally with assert_allclose(..., atol=1e-7, rtol=1e-7)

@FFroehlich FFroehlich requested a review from a team as a code owner November 26, 2024 11:50
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (b210b01) to head (b8bce77).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2601   +/-   ##
========================================
  Coverage    77.50%   77.50%           
========================================
  Files          329      329           
  Lines        22122    22122           
  Branches      1474     1474           
========================================
  Hits         17145    17145           
  Misses        4966     4966           
  Partials        11       11           
Flag Coverage Δ
cpp 73.44% <ø> (ø)
cpp_python 34.20% <ø> (ø)
petab 37.09% <ø> (ø)
python 72.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@dweindl dweindl merged commit c75909d into develop Nov 26, 2024
30 of 32 checks passed
@dweindl dweindl deleted the fix_jax_test branch November 26, 2024 13:47
@dweindl dweindl linked an issue Nov 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky python/tests/test_jax.py::test_conversion
2 participants