Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: PEtab code to sub-package #2205

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 18, 2023

Move PEtab-related code to a new amici.petab subpackage. An attempt to organize the growing codebase a bit better. More to be done. Unless anybody is using private functions, this should not break anything.

More parts to be moved separately. No change in functionality.

Keep PEtab-related code in a subpackage. An attempt to organize the growing codebase a bit better.
More to be done. Unless anybody is using private functions, this should not break anything.

More parts to be moved separately.
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #2205 (2879cf8) into develop (ffcbf66) will decrease coverage by 0.05%.
The diff coverage is 76.09%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2205      +/-   ##
===========================================
- Coverage    53.80%   53.75%   -0.05%     
===========================================
  Files           34       38       +4     
  Lines         5652     5659       +7     
===========================================
+ Hits          3041     3042       +1     
- Misses        2611     2617       +6     
Flag Coverage Δ
petab 53.75% <76.09%> (-0.05%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/__init__.py 95.55% <ø> (ø)
python/sdist/amici/petab/__init__.py 100.00% <100.00%> (ø)
python/sdist/amici/petab_import.py 76.12% <ø> (+7.87%) ⬆️
python/sdist/amici/petab_import_pysb.py 63.52% <ø> (ø)
python/sdist/amici/petab_objective.py 91.66% <ø> (+2.01%) ⬆️
python/sdist/amici/petab_util.py 0.00% <0.00%> (-89.66%) ⬇️
python/sdist/amici/petab/util.py 89.28% <89.28%> (ø)
python/sdist/amici/petab/conditions.py 96.58% <96.58%> (ø)
python/sdist/amici/petab/cli/import_petab.py 0.00% <0.00%> (ø)
python/sdist/amici/petab/parameter_mapping.py 73.79% <73.79%> (ø)

@dweindl dweindl marked this pull request as ready for review November 18, 2023 11:22
@dweindl dweindl requested a review from a team as a code owner November 18, 2023 11:22
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 67c9ca9 into AMICI-dev:develop Nov 21, 2023
8 of 9 checks passed
@dweindl dweindl deleted the refactor_petab branch November 21, 2023 19:47
dweindl added a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants