Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: fix cxx flag check #2225

Merged
merged 2 commits into from
Dec 4, 2023
Merged

CMake: fix cxx flag check #2225

merged 2 commits into from
Dec 4, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 4, 2023

Oops...

Fixes #2224

@dweindl dweindl requested a review from a team as a code owner December 4, 2023 07:51
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #2225 (5c802a0) into develop (81872cc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2225   +/-   ##
========================================
  Coverage    76.46%   76.46%           
========================================
  Files           91       91           
  Lines        15041    15041           
========================================
  Hits         11501    11501           
  Misses        3540     3540
Flag Coverage Δ
cpp 73.01% <ø> (ø)
cpp_python 37.03% <ø> (ø)
petab 53.79% <ø> (ø)
python 77.12% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dweindl dweindl linked an issue Dec 4, 2023 that may be closed by this pull request
check_cxx_compiler_flag issues with clang #2224
Closed
@dweindl dweindl merged commit c225cda into AMICI-dev:develop Dec 4, 2023
19 checks passed
@dweindl dweindl deleted the fix_2224 branch December 4, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_cxx_compiler_flag issues with clang
2 participants
@dweindl @FFroehlich