Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential out-of-bounds read in Model::checkFinite #2232

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 12, 2023

Fix potential out-of-bounds read and incorrect parameter IDs in error messages in Model::checkFinite: dwdp_ has size nw x np, not nw x nplist.

@dweindl dweindl requested a review from a team as a code owner December 12, 2023 10:24
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #2232 (77ff277) into develop (ecbae3f) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2232   +/-   ##
========================================
  Coverage    76.64%   76.64%           
========================================
  Files           91       91           
  Lines        15109    15109           
========================================
  Hits         11580    11580           
  Misses        3529     3529           
Flag Coverage Δ
cpp 73.11% <0.00%> (ø)
cpp_python 37.08% <0.00%> (ø)
petab 53.74% <ø> (ø)
python 77.44% <ø> (ø)
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/model.cpp 80.47% <0.00%> (ø)

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 1dad722 into AMICI-dev:develop Dec 12, 2023
18 of 19 checks passed
@dweindl dweindl deleted the fix_check_finite branch December 12, 2023 19:54
dweindl added a commit to ICB-DCM/parPE that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants