-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwigPtrView fields to dir() #2244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, `dir(SwigPtrView(...))` will show the available fields and sufficiently smart IDEs will show them for code completion.
dweindl
force-pushed
the
swigptr_props
branch
from
December 17, 2023 18:00
9496671
to
a0fa108
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2244 +/- ##
===========================================
- Coverage 76.64% 76.63% -0.01%
===========================================
Files 91 91
Lines 15015 15017 +2
===========================================
+ Hits 11508 11509 +1
- Misses 3507 3508 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dweindl
changed the title
Add SwigPtrView fields as properties
Add SwigPtrView fields to dir()
Dec 18, 2023
FFroehlich
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat! 👍
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way,
dir(SwigPtrView(...))
will show the available fields and sufficiently smart IDEs will show them for code completion.