Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwigPtrView fields to dir() #2244

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 17, 2023

This way, dir(SwigPtrView(...)) will show the available fields and sufficiently smart IDEs will show them for code completion.

@dweindl dweindl requested a review from a team as a code owner December 17, 2023 17:09
This way, `dir(SwigPtrView(...))` will show the available fields
and sufficiently smart IDEs will show them for code completion.
@dweindl dweindl self-assigned this Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #2244 (19f39fc) into develop (a3b1c2b) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2244      +/-   ##
===========================================
- Coverage    76.64%   76.63%   -0.01%     
===========================================
  Files           91       91              
  Lines        15015    15017       +2     
===========================================
+ Hits         11508    11509       +1     
- Misses        3507     3508       +1     
Flag Coverage Δ
cpp 73.11% <ø> (ø)
cpp_python 37.08% <ø> (ø)
petab 53.75% <50.00%> (-0.01%) ⬇️
python 77.95% <75.00%> (-0.02%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/numpy.py 85.32% <75.00%> (-0.67%) ⬇️

@dweindl dweindl marked this pull request as draft December 17, 2023 18:56
@dweindl dweindl changed the title Add SwigPtrView fields as properties Add SwigPtrView fields to dir() Dec 18, 2023
@dweindl dweindl marked this pull request as ready for review December 18, 2023 15:48
@dweindl dweindl enabled auto-merge December 20, 2023 13:37
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! 👍

@dweindl dweindl added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@dweindl dweindl added this pull request to the merge queue Jan 2, 2024
@dweindl dweindl removed this pull request from the merge queue due to a manual request Jan 2, 2024
@dweindl dweindl merged commit da93984 into AMICI-dev:develop Jan 2, 2024
17 of 19 checks passed
@dweindl dweindl deleted the swigptr_props branch January 2, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants