Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PetabProblem class for handling PEtab-defined simulation con… #2255

Merged
merged 15 commits into from
Jan 16, 2024

AmiciPetabProblem -> PetabProblem

d806546
Select commit
Loading
Failed to load commit list.
Merged

Add PetabProblem class for handling PEtab-defined simulation con… #2255

AmiciPetabProblem -> PetabProblem
d806546
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2024 in 1s

76.70% (+28.39%) compared to 3efd9f9

View this Pull Request on Codecov

76.70% (+28.39%) compared to 3efd9f9

Details

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (3efd9f9) 48.30% compared to head (d806546) 76.70%.
Report is 1 commits behind head on develop.

❗ Current head d806546 differs from pull request most recent head c8609c3. Consider uploading reports for the commit c8609c3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2255       +/-   ##
============================================
+ Coverage    48.30%   76.70%   +28.39%     
============================================
  Files           92       93        +1     
  Lines        14988    15054       +66     
============================================
+ Hits          7240    11547     +4307     
+ Misses        7748     3507     -4241     
Files Coverage Δ
python/sdist/amici/petab/conditions.py 96.58% <ø> (ø)
python/sdist/amici/petab/simulations.py 92.70% <100.00%> (-0.08%) ⬇️
python/sdist/amici/petab/petab_problem.py 0.00% <0.00%> (ø)

... and 60 files with indirect coverage changes