Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: smoother conversion from SUNMatrixWrapper to SUNMatrix #2317

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Feb 25, 2024

Adds an implicit conversion function to SUNMatrixWrapper make things more readable.

Adds an implicit conversion function to SUNMatrixWrapper make things more readable.
@dweindl dweindl requested a review from a team as a code owner February 25, 2024 18:22
@dweindl dweindl self-assigned this Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 77.78%. Comparing base (8b324bc) to head (91e6652).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2317   +/-   ##
========================================
  Coverage    77.78%   77.78%           
========================================
  Files          318      318           
  Lines        20534    20535    +1     
  Branches      1436     1436           
========================================
+ Hits         15973    15974    +1     
  Misses        4558     4558           
  Partials         3        3           
Flag Coverage Δ
cpp 73.57% <63.15%> (+<0.01%) ⬆️
cpp_python 34.01% <31.57%> (+<0.01%) ⬆️
petab 36.39% <26.31%> (+<0.01%) ⬆️
python 72.35% <63.15%> (+<0.01%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/amici/rdata.h 100.00% <100.00%> (ø)
include/amici/sundials_matrix_wrapper.h 76.54% <100.00%> (+0.29%) ⬆️
src/model.cpp 86.08% <100.00%> (ø)
src/newton_solver.cpp 70.86% <80.00%> (ø)
src/sundials_linsol_wrapper.cpp 15.31% <50.00%> (ø)
src/model_ode.cpp 66.05% <55.55%> (ø)
src/model_dae.cpp 31.16% <33.33%> (ø)

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl added this pull request to the merge queue Feb 26, 2024
Merged via the queue into AMICI-dev:develop with commit eda7ad0 Feb 26, 2024
19 of 20 checks passed
@dweindl dweindl deleted the refactor_conversion branch February 26, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants