Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught C++ exception in runAmiciSimulation #2338

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 4, 2024

Previously, an exception during ReturnData::processSimulationObjects would result in program termination.

Fixes #1882.

Previously, an exception during `ReturnData::processSimulationObjects` would result in program termination.

Fixes AMICI-dev#1882.
@dweindl dweindl requested a review from a team as a code owner March 4, 2024 08:19
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 36.85%. Comparing base (4a065e6) to head (d4e29af).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2338       +/-   ##
============================================
- Coverage    77.90%   36.85%   -41.05%     
============================================
  Files          324      103      -221     
  Lines        20723    14691     -6032     
  Branches      1448     1373       -75     
============================================
- Hits         16144     5415    -10729     
- Misses        4576     8969     +4393     
- Partials         3      307      +304     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 36.85% <14.28%> (-0.02%) ⬇️
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/amici.cpp 34.65% <14.28%> (-51.07%) ⬇️

... and 288 files with indirect coverage changes

@dweindl dweindl enabled auto-merge March 4, 2024 08:42
@dweindl dweindl disabled auto-merge March 4, 2024 08:53
@dweindl dweindl merged commit 3a6b0df into AMICI-dev:develop Mar 4, 2024
16 of 20 checks passed
@dweindl dweindl deleted the fix_1882_crash branch March 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants