Fix type annotations in swig-wrappers #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on swig options/versions, swig may or may not generate type annotations. With these changes, type annotations will be extracted from the docstrings where available, independent of the swig-generated type annotations. Closes AMICI-dev#2336.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2344 +/- ##
===========================================
- Coverage 77.70% 77.57% -0.14%
===========================================
Files 324 324
Lines 20749 20769 +20
Branches 1449 1449
===========================================
- Hits 16123 16111 -12
- Misses 4623 4655 +32
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Mar 5, 2024
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Mar 7, 2024
Some things were missing in AMICI-dev#2344
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Mar 7, 2024
Some things were missing in AMICI-dev#2344
dweindl
added a commit
that referenced
this pull request
Mar 7, 2024
Some things were missing in #2344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on swig options/versions, swig may or may not generate type annotations. With these changes, type annotations will be extracted from the docstrings where available, independent of the swig-generated type annotations.
Closes #2336.