Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solver::get_current_time #2346

Closed
wants to merge 2 commits into from

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 4, 2024

... to get the current integration time from the solver.

(also fixes a couple of incorrect exception types and messages)

Prerequisite for #2246.

@dweindl dweindl requested a review from a team as a code owner March 4, 2024 20:29
@dweindl dweindl self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 77.81%. Comparing base (e8852be) to head (fac4795).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2346      +/-   ##
===========================================
- Coverage    77.88%   77.81%   -0.07%     
===========================================
  Files          324      324              
  Lines        20731    20745      +14     
  Branches      1449     1453       +4     
===========================================
- Hits         16146    16143       -3     
- Misses        4582     4599      +17     
  Partials         3        3              
Flag Coverage Δ
cpp 73.61% <0.00%> (-0.07%) ⬇️
cpp_python 34.32% <0.00%> (-0.03%) ⬇️
petab 36.82% <0.00%> (-0.04%) ⬇️
python 72.39% <0.00%> (-0.06%) ⬇️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/amici/solver.h 100.00% <ø> (ø)
include/amici/solver_cvodes.h 100.00% <ø> (ø)
include/amici/solver_idas.h 100.00% <ø> (ø)
src/solver_cvodes.cpp 69.01% <0.00%> (-0.51%) ⬇️
src/solver_idas.cpp 36.63% <0.00%> (-0.46%) ⬇️

... and 2 files with indirect coverage changes

@dweindl
Copy link
Member Author

dweindl commented Mar 5, 2024

Wait, there is already Solver::gett. This should produce the same results.

@dweindl dweindl closed this Mar 5, 2024
@dweindl dweindl deleted the solver_cur_time branch July 1, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant