Remove deprecated functionality for PEtab import from individual files instead of petab.Problem #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `AttributeError: `np.infty` was removed in the NumPy 2.0 release. Use `np.inf` instead.`
…s instead of petab.Problem Since almost two years, it's possible to pass a `petab.Problem`, which is safer and more convenient. Omitting the parameter table for model import (since there is no option to supply this) is likely to produce unwanted results (see AMICI-dev#2458 and AMICI-dev#2455 for more details), and therefore, this functionality is best removed.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/[email protected], pypi/[email protected] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2459 +/- ##
========================================
Coverage 36.66% 36.66%
========================================
Files 103 103
Lines 14881 14881
Branches 1388 1388
========================================
Hits 5456 5456
Misses 9116 9116
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since almost two years, it's possible to pass a
petab.Problem, which is saferand more convenient.
Omitting the parameter table for model import (since there is no option to supply
this) is likely to produce unwanted results (see #2458 and #2455 for more details),
and therefore, this functionality is best removed.
Closes #2458
After #2392