Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sympy>=1.12.1 for numpy>=2.0 compatibility #2462

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 24, 2024

So far, sympy was restricted to <=1.11 via pysb, but sympy 1.11 is incompatible with numpy>=2.0

So far, sympy was restricted to 1.11 via pysb, but sympy 1.11 is incompatible with numpy>=2.0
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (043d13a) to head (f0e341e).
Report is 23 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2462       +/-   ##
============================================
+ Coverage    36.66%   77.65%   +40.98%     
============================================
  Files          103      324      +221     
  Lines        14881    20927     +6046     
  Branches      1388     1464       +76     
============================================
+ Hits          5456    16250    +10794     
+ Misses        9116     4674     -4442     
+ Partials       309        3      -306     
Flag Coverage Δ
cpp 73.41% <ø> (?)
cpp_python 34.09% <ø> (?)
petab 36.66% <ø> (ø)
python 72.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 289 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review June 24, 2024 17:49
@dweindl dweindl requested a review from a team as a code owner June 24, 2024 17:49
@dweindl dweindl self-assigned this Jun 25, 2024
@dweindl dweindl merged commit 9e31013 into AMICI-dev:develop Jun 26, 2024
20 checks passed
@dweindl dweindl deleted the min_sympy branch June 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants