Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation policy #2465

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 25, 2024

As suggested in #2458.

Other opinions?

As suggested in AMICI-dev#2458.

Other opinions?
@dweindl dweindl requested a review from a team as a code owner June 25, 2024 14:27
@dweindl dweindl requested a review from dilpath June 25, 2024 14:28
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (043d13a) to head (f261219).
Report is 24 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2465       +/-   ##
============================================
+ Coverage    36.66%   77.63%   +40.97%     
============================================
  Files          103      324      +221     
  Lines        14881    20927     +6046     
  Branches      1388     1464       +76     
============================================
+ Hits          5456    16247    +10791     
+ Misses        9116     4677     -4439     
+ Partials       309        3      -306     
Flag Coverage Δ
cpp 73.39% <ø> (?)
cpp_python 34.09% <ø> (?)
petab 36.66% <ø> (ø)
python 72.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 289 files with indirect coverage changes

@dweindl dweindl self-assigned this Jun 25, 2024
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could also add this outside of the changelog, e.g. https://amici.readthedocs.io/en/latest/development.html

@dweindl
Copy link
Member Author

dweindl commented Jun 26, 2024

could also add this outside of the changelog, e.g. https://amici.readthedocs.io/en/latest/development.html

Yes, I wasn't sure where to put it. That document says This document contains information for AMICI developers, not too relevant to regular users., so I don't think it's the right place. In the changelog it's the most visible, but I can also add a separate document on versioning, deprecation, ... policy.

@dweindl dweindl merged commit f54abe6 into AMICI-dev:develop Jun 26, 2024
18 checks passed
@dweindl dweindl deleted the deprecation_policy branch June 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants