Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use petab.v1 #2471

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Use petab.v1 #2471

merged 7 commits into from
Jul 2, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 27, 2024

Make amici ready for using libpetab's petab.v1 package instead of the previous, now deprecated imports.

Move tests/petab to tests/petab_ to avoid import issues (tests.petab namespace package vs actual petab package)

@dweindl dweindl self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (9fe31b6) to head (b56235a).
Report is 33 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2471      +/-   ##
===========================================
+ Coverage    76.20%   77.61%   +1.40%     
===========================================
  Files          319      324       +5     
  Lines        20772    20933     +161     
  Branches      1462     1464       +2     
===========================================
+ Hits         15830    16247     +417     
+ Misses        4938     4683     -255     
+ Partials         4        3       -1     
Flag Coverage Δ
cpp 73.37% <ø> (-0.02%) ⬇️
cpp_python 34.08% <ø> (ø)
petab 36.64% <ø> (?)
python 72.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/cli/import_petab.py 0.00% <ø> (ø)
python/sdist/amici/petab/conditions.py 97.43% <ø> (+23.93%) ⬆️
python/sdist/amici/petab/import_helpers.py 86.15% <ø> (+7.69%) ⬆️
python/sdist/amici/petab/parameter_mapping.py 81.15% <ø> (+28.27%) ⬆️
python/sdist/amici/petab/petab_import.py 66.66% <ø> (ø)
python/sdist/amici/petab/petab_problem.py 87.69% <ø> (+87.69%) ⬆️
python/sdist/amici/petab/pysb_import.py 51.85% <ø> (+46.29%) ⬆️
python/sdist/amici/petab/sbml_import.py 54.28% <ø> (+27.14%) ⬆️
python/sdist/amici/petab/simulations.py 92.85% <ø> (+22.44%) ⬆️
python/sdist/amici/petab/simulator.py 100.00% <ø> (+100.00%) ⬆️
... and 5 more

... and 8 files with indirect coverage changes

@dweindl dweindl changed the title Test petab/develop Use petab.v1 Jul 1, 2024
@dweindl dweindl mentioned this pull request Jul 1, 2024
3 tasks
@dweindl dweindl force-pushed the test_petab_develop branch from 8810ec2 to 5614098 Compare July 1, 2024 11:51
@dweindl dweindl marked this pull request as ready for review July 1, 2024 21:22
@dweindl dweindl requested a review from a team as a code owner July 1, 2024 21:22
@dweindl dweindl merged commit 6fe648e into AMICI-dev:develop Jul 2, 2024
20 checks passed
@dweindl dweindl deleted the test_petab_develop branch July 2, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants