Release 0.26.1 #2485

dweindl · 2024-07-11T07:36:10Z

No description provided.

see https://cmake.org/cmake/help/latest/policy/CMP0167.html Closes AMICI-dev#2476

We have a couple of -Werror options enabled when running on GHA. However, we should also check for the repo name. If amici is used in tests of any downstream projects, we don't want errors. Also use CMake's `-Wno-dev` for non-amici-ci installations. Fixes AMICI-dev#2477

Update the minimum required gcc version to provide a more actionable warning than sth like `'reduce' is not a member of 'std'` (see e.g. AMICI-dev#2463).

Catch all exceptions in omp parallel regions. Fixes AMICI-dev#2478.

codecov · 2024-07-11T08:00:25Z

Codecov Report

Attention: Patch coverage is 47.36842% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (b958cce) to head (86b1c59).
Report is 40 commits behind head on master.

Files with missing lines	Patch %	Lines
src/splinefunctions.cpp	29.41%	12 Missing ⚠️
src/sundials_linsol_wrapper.cpp	0.00%	5 Missing ⚠️
src/exception.cpp	33.33%	2 Missing ⚠️
src/rdata.cpp	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
+ Coverage   77.65%   77.81%   +0.15%     
==========================================
  Files         324      324              
  Lines       20933    20941       +8     
  Branches     1462     1456       -6     
==========================================
+ Hits        16256    16295      +39     
+ Misses       4674     4643      -31     
  Partials        3        3

Flag	Coverage Δ
cpp	`76.21% <47.36%> (+2.79%)`	⬆️
cpp_python	`34.08% <36.84%> (-0.01%)`	⬇️
petab	`36.63% <18.91%> (-0.02%)`	⬇️
python	`72.36% <42.10%> (+0.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
include/amici/model_dae.h	`72.72% <100.00%> (ø)`
include/amici/model_ode.h	`100.00% <100.00%> (ø)`
src/amici.cpp	`81.41% <ø> (ø)`
src/edata.cpp	`83.07% <100.00%> (+0.92%)`	⬆️
src/newton_solver.cpp	`70.63% <100.00%> (ø)`
src/spline.cpp	`64.89% <ø> (ø)`
src/rdata.cpp	`95.36% <80.00%> (ø)`
src/exception.cpp	`69.69% <33.33%> (-9.10%)`	⬇️
src/sundials_linsol_wrapper.cpp	`15.31% <0.00%> (ø)`
src/splinefunctions.cpp	`77.59% <29.41%> (+0.14%)`	⬆️

... and 5 files with indirect coverage changes

FFroehlich

👍

dweindl and others added 7 commits July 2, 2024 15:15

Fix release date

837e70b

CMake: Set CMP0167 (AMICI-dev#2480)

ba2a117

see https://cmake.org/cmake/help/latest/policy/CMP0167.html Closes AMICI-dev#2476

Update gcc minimum required version warning (AMICI-dev#2482)

42dc328

Update the minimum required gcc version to provide a more actionable warning than sth like `'reduce' is not a member of 'std'` (see e.g. AMICI-dev#2463).

Fix uncaught C++ exceptions crashing Python (AMICI-dev#2484)

954fe8b

Catch all exceptions in omp parallel regions. Fixes AMICI-dev#2478.

Run clang-format

37ba89d

Bump version; update changelog

86b1c59

dweindl requested a review from a team as a code owner July 11, 2024 07:36

FFroehlich approved these changes Jul 11, 2024

View reviewed changes

dweindl merged commit b0d79ff into AMICI-dev:master Jul 11, 2024
26 of 27 checks passed

dweindl deleted the release_0.26.1 branch July 11, 2024 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.26.1 #2485

Release 0.26.1 #2485

dweindl commented Jul 11, 2024

codecov bot commented Jul 11, 2024 •

edited

Loading

FFroehlich left a comment

Release 0.26.1 #2485

Release 0.26.1 #2485

Conversation

dweindl commented Jul 11, 2024

codecov bot commented Jul 11, 2024 • edited Loading

Codecov Report

FFroehlich left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 11, 2024 •

edited

Loading