Tests: Fix petab benchmark models paths #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming scheme changed. Use provided library to constructs paths.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2488 +/- ##
========================================
Coverage 77.68% 77.68%
========================================
Files 324 324
Lines 20941 20941
Branches 1456 1456
========================================
Hits 16267 16267
Misses 4671 4671
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. |
FFroehlich
reviewed
Aug 1, 2024
| @@ -61,6 +61,7 @@ jobs: | |||
| run: | | |||
| git clone --depth 1 https://github.com/benchmarking-initiative/Benchmark-Models-PEtab.git \ | |||
| && export BENCHMARK_COLLECTION="$(pwd)/Benchmark-Models-PEtab/Benchmark-Models/" \ | |||
There was a problem hiding this comment.
we don't need BENCHMARK_COLLECTION anymore, right?
There was a problem hiding this comment.
It's still used in tests/benchmark-models/test_benchmark_collection.sh. At some point, this should be replaced by pytest tests, though, and use the benchmark models Python package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming scheme changed. Use provided library to constructs paths.