Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ModelDimension and initialization of ModelStateDerived #2507

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 26, 2024

  • Move some other model dimensions from the Model constructor to ModelDimensions
  • Perform more initialization of ModelStateDerived inside its constructor

@dweindl dweindl self-assigned this Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (de1804a) to head (850d4cc).
Report is 103 commits behind head on develop.

Files with missing lines Patch % Lines
include/amici/model_dimensions.h 62.50% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2507      +/-   ##
===========================================
- Coverage    77.71%   77.68%   -0.04%     
===========================================
  Files          324      324              
  Lines        21725    20946     -779     
  Branches      1451     1451              
===========================================
- Hits         16883    16271     -612     
+ Misses        4839     4672     -167     
  Partials         3        3              
Flag Coverage Δ
cpp 73.42% <89.79%> (-0.19%) ⬇️
cpp_python 34.09% <73.46%> (-0.01%) ⬇️
petab 36.61% <76.59%> (+0.01%) ⬆️
python 72.23% <87.75%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/model.h 76.19% <ø> (ø)
include/amici/model_dae.h 72.72% <ø> (ø)
include/amici/model_ode.h 100.00% <ø> (ø)
include/amici/model_state.h 100.00% <ø> (ø)
src/model.cpp 84.46% <100.00%> (-0.01%) ⬇️
src/model_state.cpp 100.00% <100.00%> (ø)
include/amici/model_dimensions.h 46.47% <62.50%> (+1.16%) ⬆️

... and 80 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review September 26, 2024 16:02
@dweindl dweindl requested a review from a team as a code owner September 26, 2024 16:02
* Move some other model dimensions from the Model constructor to ModelDimensions
* Perform more initialization of ModelStateDerived inside its constructor
@dweindl dweindl added this pull request to the merge queue Sep 27, 2024
Merged via the queue into AMICI-dev:develop with commit 823b6bd Sep 27, 2024
20 checks passed
@dweindl dweindl deleted the refactor_modeldim branch September 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants