Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMake>=3.22 #2508

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Require CMake>=3.22 #2508

merged 4 commits into from
Sep 27, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Sep 26, 2024

  • Require CMake>=3.22, which is what SuiteSparse already requires
  • Regenerate model code to get rid of various warnings

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.67%. Comparing base (de1804a) to head (6fe8b41).
Report is 103 commits behind head on develop.

Files with missing lines Patch % Lines
models/model_calvetti/model_calvetti.h 0.00% 1 Missing ⚠️
models/model_dirac/model_dirac.h 0.00% 1 Missing ⚠️
models/model_events/model_events.h 0.00% 1 Missing ⚠️
...dels/model_jakstat_adjoint/model_jakstat_adjoint.h 0.00% 1 Missing ⚠️
...odel_jakstat_adjoint_o2/model_jakstat_adjoint_o2.h 0.00% 1 Missing ⚠️
models/model_nested_events/model_nested_events.h 0.00% 1 Missing ⚠️
models/model_neuron/model_neuron.h 0.00% 1 Missing ⚠️
models/model_neuron_o2/model_neuron_o2.h 0.00% 1 Missing ⚠️
models/model_robertson/model_robertson.h 0.00% 1 Missing ⚠️
models/model_steadystate/model_steadystate.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2508      +/-   ##
===========================================
- Coverage    77.71%   77.67%   -0.04%     
===========================================
  Files          324      324              
  Lines        21725    20935     -790     
  Branches      1451     1449       -2     
===========================================
- Hits         16883    16262     -621     
+ Misses        4839     4670     -169     
  Partials         3        3              
Flag Coverage Δ
cpp 73.41% <0.00%> (-0.20%) ⬇️
cpp_python 34.10% <0.00%> (ø)
petab 36.59% <ø> (ø)
python 72.23% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
models/model_calvetti/model_calvetti.h 41.26% <0.00%> (ø)
models/model_dirac/model_dirac.h 54.83% <0.00%> (ø)
models/model_events/model_events.h 70.67% <0.00%> (+1.37%) ⬆️
...dels/model_jakstat_adjoint/model_jakstat_adjoint.h 66.15% <0.00%> (ø)
...odel_jakstat_adjoint_o2/model_jakstat_adjoint_o2.h 66.15% <0.00%> (ø)
models/model_nested_events/model_nested_events.h 56.92% <0.00%> (ø)
models/model_neuron/model_neuron.h 75.71% <0.00%> (-0.15%) ⬇️
models/model_neuron_o2/model_neuron_o2.h 82.71% <0.00%> (ø)
models/model_robertson/model_robertson.h 54.68% <0.00%> (ø)
models/model_steadystate/model_steadystate.h 64.51% <0.00%> (ø)

... and 79 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review September 26, 2024 16:02
@dweindl dweindl requested a review from a team as a code owner September 26, 2024 16:02
@dweindl dweindl enabled auto-merge September 27, 2024 04:03
@dweindl dweindl added this pull request to the merge queue Sep 27, 2024
Merged via the queue into AMICI-dev:develop with commit 9a81ad1 Sep 27, 2024
18 of 20 checks passed
@dweindl dweindl deleted the regenerate_models branch September 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants