Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NewtonSolver #2521

Merged
merged 1 commit into from
Oct 3, 2024

Refactor NewtonSolver

39dfa38
Select commit
Loading
Failed to load commit list.
Merged

Refactor NewtonSolver #2521

Refactor NewtonSolver
39dfa38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

77.75% (+0.07%) compared to c199897

View this Pull Request on Codecov

77.75% (+0.07%) compared to c199897

Details

Codecov Report

Attention: Patch coverage is 70.12987% with 23 lines in your changes missing coverage. Please review.

Project coverage is 77.75%. Comparing base (c199897) to head (39dfa38).

Files with missing lines Patch % Lines
src/newton_solver.cpp 73.07% 14 Missing ⚠️
src/sundials_linsol_wrapper.cpp 47.05% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2521      +/-   ##
===========================================
+ Coverage    77.67%   77.75%   +0.07%     
===========================================
  Files          324      323       -1     
  Lines        20951    20915      -36     
  Branches      1451     1446       -5     
===========================================
- Hits         16274    16262      -12     
+ Misses        4674     4650      -24     
  Partials         3        3              
Files with missing lines Coverage Δ
include/amici/steadystateproblem.h 100.00% <ø> (ø)
include/amici/sundials_linsol_wrapper.h 100.00% <ø> (ø)
src/steadystateproblem.cpp 83.92% <100.00%> (ø)
src/sundials_linsol_wrapper.cpp 22.31% <47.05%> (+5.64%) ⬆️
src/newton_solver.cpp 80.51% <73.07%> (+9.88%) ⬆️