Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move Model::state_ initalization to ModelState ctor #2533

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 8, 2024

Move Model::state_ initalization to ModelState ctor where it belongs.

Closes #2531.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (b7a3e91) to head (5d4bbb8).
Report is 80 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2533   +/-   ##
========================================
  Coverage    77.79%   77.79%           
========================================
  Files          325      325           
  Lines        21053    21057    +4     
  Branches      1473     1473           
========================================
+ Hits         16378    16382    +4     
  Misses        4648     4648           
  Partials        27       27           
Flag Coverage Δ
cpp 73.51% <100.00%> (+<0.01%) ⬆️
cpp_python 34.05% <100.00%> (+0.01%) ⬆️
petab 37.05% <100.00%> (+0.01%) ⬆️
python 72.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/model_state.h 78.26% <100.00%> (+1.40%) ⬆️
src/model.cpp 84.44% <100.00%> (-0.03%) ⬇️

Move `Model::state_` initalization to `ModelState` ctor where it belongs.

Closes AMICI-dev#2531.
@dweindl dweindl force-pushed the refactor_ModelState_ctor branch from d1a70bd to 2a48adf Compare October 8, 2024 10:06
@dweindl dweindl self-assigned this Oct 8, 2024
@dweindl dweindl marked this pull request as ready for review October 9, 2024 10:02
@dweindl dweindl requested a review from a team as a code owner October 9, 2024 10:02
@dweindl dweindl merged commit f5533ba into AMICI-dev:develop Oct 10, 2024
19 of 20 checks passed
@dweindl dweindl deleted the refactor_ModelState_ctor branch October 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants