Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SBML test IDs #2536

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix SBML test IDs #2536

merged 1 commit into from
Oct 9, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 8, 2024

Make sure the printed test IDs correspond to actual test IDs, so they can be copy/pasted to rerun. Previously this was not the case when running with pytest-xdist.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (e59e415) to head (fd5fedc).
Report is 82 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2536      +/-   ##
===========================================
- Coverage    77.78%   77.73%   -0.05%     
===========================================
  Files          325      325              
  Lines        21047    21047              
  Branches      1473     1473              
===========================================
- Hits         16371    16361      -10     
- Misses        4649     4659      +10     
  Partials        27       27              
Flag Coverage Δ
cpp 73.44% <ø> (-0.05%) ⬇️
cpp_python 34.02% <ø> (ø)
petab 37.03% <ø> (ø)
python 72.27% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review October 8, 2024 14:13
@dweindl dweindl requested a review from a team as a code owner October 8, 2024 14:13
@dweindl dweindl self-assigned this Oct 9, 2024
Make sure the printed test IDs correspond to actual test IDs, so they can be copy/pasted to rerun.
Previously this was not the case when running with pytest-xdist.
@dweindl dweindl force-pushed the fix_sbml_test_ids branch from 92fc3f1 to fd5fedc Compare October 9, 2024 08:55
@dweindl dweindl merged commit 2f70528 into AMICI-dev:develop Oct 9, 2024
24 of 26 checks passed
@dweindl dweindl deleted the fix_sbml_test_ids branch October 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants