Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update jax notebook #2552

Merged
merged 2 commits into from
Oct 19, 2024
Merged

update jax notebook #2552

merged 2 commits into from
Oct 19, 2024

Conversation

FFroehlich
Copy link
Member

fixes #2529
fixes #2527

@FFroehlich FFroehlich requested a review from a team as a code owner October 19, 2024 08:28
@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (8253a97) to head (a5d6280).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2552      +/-   ##
===========================================
+ Coverage    77.75%   77.78%   +0.03%     
===========================================
  Files          325      325              
  Lines        21852    21852              
  Branches      1473     1473              
===========================================
+ Hits         16991    16998       +7     
+ Misses        4834     4827       -7     
  Partials        27       27
Flag Coverage Δ
cpp 73.65% <ø> (+0.03%) ⬆️
cpp_python 34.20% <ø> (ø)
petab 37.06% <ø> (ø)
python 72.42% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

dweindl
dweindl approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

python/examples/example_jax/ExampleJax.ipynb Outdated Show resolved Hide resolved
python/examples/example_jax/ExampleJax.ipynb Outdated Show resolved Hide resolved
python/examples/example_jax/ExampleJax.ipynb Outdated Show resolved Hide resolved
@FFroehlich FFroehlich enabled auto-merge October 19, 2024 09:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FFroehlich FFroehlich added this pull request to the merge queue Oct 19, 2024
Merged via the queue into develop with commit 8f0c8fb Oct 19, 2024
31 of 32 checks passed
@FFroehlich FFroehlich deleted the fix_jax_notebook branch December 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FFroehlich @dweindl