Change default steady-state method to integrationOnly
#2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2574 +/- ##
===========================================
- Coverage 77.76% 77.75% -0.01%
===========================================
Files 325 325
Lines 21861 21861
Branches 1473 1473
===========================================
- Hits 17000 16999 -1
- Misses 4834 4835 +1
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Nov 9, 2024
**Breaking change** Change the default mode for computing steady states and sensitivities at steady state to `integrationOnly` (from previously `integrateIfNewtonFails`). This is done for a more robust default behaviour. For example, the evaluation in https://doi.org/10.1371/journal.pone.0312148 shows that - at least for some models - Newton's method may easily lead to physically impossible solutions. To keep the previous behaviour, use: ```python amici_model.setSteadyStateComputationMode(amici.SteadyStateComputationMode.integrateIfNewtonFails) amici_model.setSteadyStateSensitivityMode(amici.SteadyStateSensitivityMode.integrateIfNewtonFails) ``` Closes AMICI-dev#2571.
dweindl
force-pushed
the
gh2571_default_ssmode
branch
from
4888cfd to
e47ef3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Change the default mode for computing steady states and sensitivities at steady state to
integrationOnly(from previouslyintegrateIfNewtonFails).This is done for a more robust default behaviour. For example, the evaluation in https://doi.org/10.1371/journal.pone.0312148 shows that - at least for some models - Newton's method may easily lead to physically impossible solutions.
To keep the previous behaviour, use:
Closes #2571.