Fix potentially incorrect disabling of Newton's method #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSensitivityMode::integrationOnly` Fixes a bug that would result in disabling Newton's method for steady-state computation when steady-state sensitivity mode is set to `integrationOnly`, even if no senitivities are computed. This was because only the sensitivity method was checked, but not the sensitivity order. Fixes AMICI-dev#2575.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2576 +/- ##
========================================
Coverage 77.76% 77.76%
========================================
Files 325 325
Lines 21861 21862 +1
Branches 1473 1473
========================================
+ Hits 17000 17001 +1
Misses 4834 4834
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FFroehlich
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that would result in disabling Newton's method for steady-state computation when steady-state sensitivity mode is set to
integrationOnly, even if no senitivities are computed.This was because only the sensitivity method was checked, but not the sensitivity order.
The problem exists since
Model::setSteadyStateSensitivityModewas introduced (#2074, v0.19.0 (2023-08-26)).Fixes #2575.