Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Solver::newton_maxlinsteps_ #2592

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 23, 2024

Left over from #1732.

Closes #2590.

@dweindl dweindl requested a review from a team as a code owner November 23, 2024 16:52
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (7ba2165) to head (a339089).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2592   +/-   ##
========================================
  Coverage    77.63%   77.63%           
========================================
  Files          329      329           
  Lines        22061    22061           
  Branches      1456     1456           
========================================
  Hits         17126    17126           
  Misses        4924     4924           
  Partials        11       11           
Flag Coverage Δ
cpp 73.56% <ø> (ø)
cpp_python 34.30% <ø> (ø)
petab 37.23% <ø> (ø)
python 72.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/solver.h 94.11% <ø> (ø)
---- 🚨 Try these New Features:

@dweindl dweindl merged commit d72f8c2 into AMICI-dev:develop Nov 24, 2024
18 of 20 checks passed
@dweindl dweindl deleted the fix_2590 branch November 24, 2024 09:20
@dweindl dweindl linked an issue Nov 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writeSolverSettingsToHDF5 does not store all Solver members
2 participants