Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update valgrind suppressions / skip #2600

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update valgrind suppressions / skip #2600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dce525
Update valgrind suppression / skip
dweindl Nov 26, 2024
6675303
..
dweindl Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test_valgrind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,9 @@ jobs:
- name: Install python package
run: scripts/installAmiciSource.sh

- name: Remove jax
# avoid valgrind errors due to jax et al.
run: venv/bin/pip uninstall -y jax

- name: Python tests / Valgrind
run: scripts/run-valgrind-py.sh
4 changes: 3 additions & 1 deletion python/tests/test_jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@
from beartype import beartype

from amici.pysb_import import pysb2amici
from amici.testing import TemporaryDirectoryWinSafe
from amici.testing import TemporaryDirectoryWinSafe, skip_on_valgrind
from numpy.testing import assert_allclose

pysb = pytest.importorskip("pysb")

jax.config.update("jax_enable_x64", True)


@skip_on_valgrind
def test_conversion():
pysb.SelfExporter.cleanup() # reset pysb
pysb.SelfExporter.do_export = True
Expand All @@ -42,6 +43,7 @@ def test_conversion():
_test_model(model_module, ts, p, k)


@skip_on_valgrind
@pytest.mark.filterwarnings(
"ignore:Model does not contain any initial conditions"
)
Expand Down
9 changes: 9 additions & 0 deletions python/tests/valgrind-python.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,3 +985,12 @@
fun:_PyTuple_Resize
...
}

{
Python
Memcheck:Cond
fun:PyObject_RichCompareBool
fun:tuplerichcompare
fun:do_richcompare
...
}
Loading