Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ReturnData fields in writeReturnData #2602

Merged
merged 1 commit into from
Nov 27, 2024

Add missing ReturnData fields in writeReturnData

1430970
Select commit
Loading
Failed to load commit list.
Merged

Add missing ReturnData fields in writeReturnData #2602

Add missing ReturnData fields in writeReturnData
1430970
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 0s

77.59% (+0.03%) compared to c75909d

View this Pull Request on Codecov

77.59% (+0.03%) compared to c75909d

Details

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.59%. Comparing base (c75909d) to head (1430970).

Files with missing lines Patch % Lines
src/hdf5.cpp 94.73% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2602      +/-   ##
===========================================
+ Coverage    77.56%   77.59%   +0.03%     
===========================================
  Files          329      329              
  Lines        21637    21693      +56     
  Branches      1470     1477       +7     
===========================================
+ Hits         16782    16832      +50     
- Misses        4844     4850       +6     
  Partials        11       11              
Files with missing lines Coverage Δ
include/amici/rdata.h 100.00% <ø> (ø)
src/hdf5.cpp 85.16% <94.73%> (+0.68%) ⬆️

... and 3 files with indirect coverage changes