Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple JAX & C++ code generation #2615

Merged
merged 11 commits into from
Dec 3, 2024

Merge branch 'develop' into decouple_jax_module

45c67b2
Select commit
Loading
Failed to load commit list.
Merged

Decouple JAX & C++ code generation #2615

Merge branch 'develop' into decouple_jax_module
45c67b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 3, 2024 in 1s

36.57% (-41.23%) compared to bd3bd91

View this Pull Request on Codecov

36.57% (-41.23%) compared to bd3bd91

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 62 lines in your changes missing coverage. Please review.

Project coverage is 36.57%. Comparing base (bd3bd91) to head (45c67b2).

Files with missing lines Patch % Lines
python/sdist/amici/jax/ode_export.py 0.00% 50 Missing ⚠️
python/sdist/amici/pysb_import.py 27.27% 8 Missing ⚠️
python/sdist/amici/sbml_import.py 33.33% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bd3bd91) and HEAD (45c67b2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bd3bd91) HEAD (45c67b2)
cpp 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2615       +/-   ##
============================================
- Coverage    77.80%   36.57%   -41.23%     
============================================
  Files          329      330        +1     
  Lines        21737    21833       +96     
  Branches      1477     1477               
============================================
- Hits         16912     7986     -8926     
- Misses        4814    13823     +9009     
- Partials        11       24       +13     
Files with missing lines Coverage Δ
python/sdist/amici/__init__.py 86.27% <ø> (-7.85%) ⬇️
python/sdist/amici/de_export.py 93.76% <100.00%> (-2.86%) ⬇️
python/sdist/amici/jax/jaxcodeprinter.py 0.00% <ø> (ø)
python/sdist/amici/petab/import_helpers.py 85.93% <ø> (ø)
python/sdist/amici/petab/petab_import.py 66.66% <ø> (ø)
python/sdist/amici/petab/pysb_import.py 51.85% <ø> (ø)
python/sdist/amici/petab/sbml_import.py 73.33% <100.00%> (+19.04%) ⬆️
python/sdist/amici/sbml_import.py 65.48% <33.33%> (-14.09%) ⬇️
python/sdist/amici/pysb_import.py 92.00% <27.27%> (-2.31%) ⬇️
python/sdist/amici/jax/ode_export.py 0.00% <0.00%> (ø)

... and 240 files with indirect coverage changes