Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2642 #2643

Merged
merged 5 commits into from
Feb 5, 2025
Merged

fix #2642 #2643

merged 5 commits into from
Feb 5, 2025

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from a team as a code owner January 31, 2025 18:20
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (64de63a) to head (a0e3113).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
python/sdist/amici/sbml_import.py 66.66% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2643      +/-   ##
===========================================
- Coverage    77.06%   77.06%   -0.01%     
===========================================
  Files          332      332              
  Lines        23012    23021       +9     
  Branches      1478     1478              
===========================================
+ Hits         17735    17740       +5     
- Misses        5266     5270       +4     
  Partials        11       11              
Flag Coverage Δ
cpp 74.16% <66.66%> (-0.01%) ⬇️
cpp_python 33.41% <50.00%> (-0.01%) ⬇️
petab 39.00% <50.00%> (-0.01%) ⬇️
python 72.15% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 79.25% <66.66%> (-0.21%) ⬇️

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

It would be great if you could add the example from #2642 as test.

@FFroehlich FFroehlich enabled auto-merge February 5, 2025 11:47
Copy link

sonarqubecloud bot commented Feb 5, 2025

@FFroehlich FFroehlich added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit c9f698d Feb 5, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants