Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erick/production 1.0 #106

Open
wants to merge 83 commits into
base: development
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
7a53b35
Make IMFP calculation energy dependent
shankar-1729 Nov 4, 2024
de0bac5
Ensure that rho, temp and Ye are uniformally spaced.
shankar-1729 Nov 4, 2024
7daa907
Implement function to calculate maximum of IMFP over the grid (UNTESTED)
shankar-1729 Oct 26, 2024
2c67c2e
Move multifab for IMFB inside compute_max_IMFP function, correct temp…
shankar-1729 Oct 30, 2024
795615c
do not input ba, dm and ngrow inside compute_max_IMFP function
shankar-1729 Oct 30, 2024
a9d22c4
calculate max_IMFP_abs inside function compute_dt
shankar-1729 Oct 30, 2024
66eeb3c
Remove dt calculation from compute_dt function
shankar-1729 Oct 31, 2024
3480a61
Adding basics comments and documentation to new functions
erickurquilla1999 Nov 4, 2024
8458eae
Change the position of the calculation of the maximum IMFP
erickurquilla1999 Nov 4, 2024
792c8fd
Compute maximum of IMFP when IMFP method is 1 too
erickurquilla1999 Nov 4, 2024
4b43fff
Compute the maximum IMFP and pass it as a parameter to the compute_dt…
erickurquilla1999 Nov 4, 2024
db60725
Cleaning up the compute_dt function and adding documentation.
erickurquilla1999 Nov 4, 2024
d02f865
Include a generated file to compute the trace of the neutrino number …
erickurquilla1999 Nov 4, 2024
0959355
Solving issue in generated file to compute trace of mesh neutrino and…
erickurquilla1999 Nov 4, 2024
b4c008b
Compute maximum trace of the neutrino and antineutrino from mesh quan…
erickurquilla1999 Nov 4, 2024
0399808
Create a function that computes the minimum value in a MultiFab in pa…
erickurquilla1999 Nov 5, 2024
be783b9
Set some if statements to handle simulations with empty periodic boun…
erickurquilla1999 Nov 5, 2024
d8e9f1e
Generate a new file to compute the trace on mesh quantities
erickurquilla1999 Nov 5, 2024
c5c70ed
Solve syntaxis mistakes and compute the minumin time step rather than…
erickurquilla1999 Nov 5, 2024
9703bac
Make function compute_max_IMFP return a multifab with the maximum inv…
erickurquilla1999 Nov 5, 2024
aada239
Compute the minimum combination of TrN/Opacity*c. This quantity provi…
erickurquilla1999 Nov 5, 2024
8a737ea
Delete commented lines and handle periodic empty boundary conditions …
erickurquilla1999 Nov 5, 2024
3420c23
Cleaning up and addiing comments to the compute_dt function
erickurquilla1999 Nov 5, 2024
4594186
Add documentation for header file of Evolve.cpp file
erickurquilla1999 Nov 5, 2024
acbf75d
Delete unnecessary generation of two files that compute the trace.
erickurquilla1999 Nov 5, 2024
2296774
Setting the min(TrN, TrNbar) to one in case it is zero
erickurquilla1999 Nov 5, 2024
97e981e
Cleaning space
erickurquilla1999 Nov 5, 2024
c1be327
Cleaning up compute_max_IMFP function
erickurquilla1999 Nov 5, 2024
af7a2c8
Creating documentation for compute_max_IMFP function
erickurquilla1999 Nov 5, 2024
08fc11f
Set the new time step to agree with the new function that computes th…
erickurquilla1999 Nov 5, 2024
dac02e9
Solving issue when looping over the MultiFabs. Now it does not loop o…
erickurquilla1999 Nov 6, 2024
f76d6fb
Delete unnecessary lines
erickurquilla1999 Nov 6, 2024
1021c4e
Update empty periodic boundary condition test
erickurquilla1999 Nov 6, 2024
aa6f913
Setting the right cfl factors for particles to equilibrium test
erickurquilla1999 Nov 6, 2024
ec29a9b
Set up the Fermi-Dirac test for multi-energy particles with the follo…
erickurquilla1999 Nov 6, 2024
8f7094b
Delete unnecessary functions
erickurquilla1999 Nov 6, 2024
a114cc8
Solving possible issue with zero inverse mean free path
erickurquilla1999 Nov 6, 2024
7358916
Improve documentation
erickurquilla1999 Nov 6, 2024
2a3525d
Solve syntax issue
erickurquilla1999 Nov 6, 2024
94a9bf2
Solving issue with fermi dirac test
erickurquilla1999 Nov 7, 2024
3f60f26
Fix time step function: now calculates the time step based on a basic…
erickurquilla1999 Nov 25, 2024
f1c9cd7
Adding comments on the definitions of V_stupid and V_adaptive
erickurquilla1999 Nov 25, 2024
216fc2a
Delete unnecessary line that computes the trace of matrices.
erickurquilla1999 Nov 25, 2024
f09220b
Add input parameter for the minimum allowed time step in the simulation
erickurquilla1999 Nov 25, 2024
981c3e2
Including the minimum time step barrier in the function that computes…
erickurquilla1999 Nov 25, 2024
94af9fb
Including a new neutrino container to store the minimum dt for every …
erickurquilla1999 Nov 25, 2024
9255937
Delete documentation in Evolve.H header file and input the time step …
erickurquilla1999 Nov 25, 2024
bd4be86
Add a flag to choose between two different methods for computing the …
erickurquilla1999 Nov 25, 2024
2835ede
Add a new method to compute the time step based on the time derivativ…
erickurquilla1999 Nov 25, 2024
e49ff1b
Delete unnecessary variables and comments.
erickurquilla1999 Nov 25, 2024
d437789
Add time_step_method flag to input parameters.
erickurquilla1999 Nov 25, 2024
4873d89
Update input parameters.
erickurquilla1999 Nov 25, 2024
f5e9e71
Improve script that compute dE and antineutrino chemical potential fo…
erickurquilla1999 Nov 25, 2024
f37885e
Setting asserts at the end of the collisional flavor instability test…
erickurquilla1999 Nov 25, 2024
5ed145b
Fix issue with Method 1 for computing the time step
erickurquilla1999 Nov 25, 2024
c7dbd0d
Set collisional flavor instability test to use Method 1 for computing…
erickurquilla1999 Nov 25, 2024
e8f4b84
Fix issue in method 0 to compute time step
erickurquilla1999 Nov 25, 2024
d6c37a4
Adding comments in st9 initial condition to avoid future confusion
erickurquilla1999 Nov 25, 2024
653bc78
Adding comments to avoid future confusion in fermi-dirac test
erickurquilla1999 Nov 25, 2024
40a853b
Remove 'FIXME' comments.
erickurquilla1999 Nov 25, 2024
34f27cf
Return mf_IMFP at the end of the function instead of in every if stat…
erickurquilla1999 Nov 25, 2024
a5f4b30
Delete print line in main
erickurquilla1999 Nov 25, 2024
c2aa1b4
Create a script to plot the polarization vector components for single…
erickurquilla1999 Nov 25, 2024
501fe69
Add an if statement to compute the IMFP MultiFab only when the time s…
erickurquilla1999 Nov 25, 2024
1652a0e
Set the maximum grid size for every direction in the domain.
erickurquilla1999 Nov 25, 2024
61c025d
Update input file to define max grid size in every direction in the d…
erickurquilla1999 Nov 25, 2024
86e8500
Making convertToHDF5.py script works in 3D simulations
erickurquilla1999 Nov 27, 2024
0de65c0
Adding a line to stop execution when a NaN appears in N and N bar
erickurquilla1999 Nov 29, 2024
e02dc74
Improve section the leave the code is N or Nbar is NaN
erickurquilla1999 Nov 29, 2024
9ea0ae6
Plotting best figures in collisional instability test
erickurquilla1999 Dec 2, 2024
8b44a36
Adding units to labels and legends
erickurquilla1999 Dec 2, 2024
104bb0f
Updating plots and legens in CFI test
erickurquilla1999 Dec 2, 2024
8c92437
Delete lines that import unused packages in the collisional instabili…
erickurquilla1999 Dec 4, 2024
4e61f3d
Setting optimal max_grid_size in tests input file
erickurquilla1999 Dec 4, 2024
e01666d
Add a script to save particle information from binary to HDF5, organi…
erickurquilla1999 Jan 4, 2025
b403f71
Optimizing script that write particles data per cell. Now it only doe…
erickurquilla1999 Jan 4, 2025
e37eeb7
Create a new script for parallel optimization of the write_partices_p…
erickurquilla1999 Jan 4, 2025
773a933
Adding an script that write particle information parallelized over grids
erickurquilla1999 Jan 4, 2025
2d5a3c6
Solving issue creating particles file
erickurquilla1999 Jan 4, 2025
3c62f34
Delete thread parallelization
erickurquilla1999 Jan 4, 2025
bfbba28
Update write particles per cell script to recive the grid index as in…
erickurquilla1999 Jan 4, 2025
2ab5ab3
Delete file
erickurquilla1999 Jan 4, 2025
cdd589e
Fix issue with number of amrex grid subdivision
erickurquilla1999 Jan 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete unnecessary functions
erickurquilla1999 committed Nov 7, 2024
commit 8f7094b013b1789cade7801f9d743d2e00ede87d
50 changes: 0 additions & 50 deletions Source/Evolve.cpp
Original file line number Diff line number Diff line change
@@ -86,56 +86,6 @@ template <typename T> static inline AMREX_GPU_DEVICE T max6(T a, T b, T c, T d,
return max(max3(a, b, c), max3(d, e, f));
}

/**
* @brief Computes the maximum Inverse Mean Free Path (IMFP) from a given MultiFab.
*
* This function performs a parallel reduction to find the maximum value of the
* Inverse Mean Free Path (IMFP) stored in the provided MultiFab. It uses the
* ParReduce function with a maximum reduction operation.
*
* @param mf_IMFP The MultiFab containing the IMFP values. It is assumed that
* the MultiFab is properly initialized and contains valid data.
*
* @return The maximum IMFP value found in the MultiFab.
*/
Real compute_max_IMFP_from_mf (MultiFab const& mf_IMFP)
{
auto const& ma = mf_IMFP.const_arrays();
return ParReduce(TypeList<ReduceOpMax>{}, TypeList<Real>{},
mf_IMFP, IntVect(0), // zero ghost cells
[=] AMREX_GPU_DEVICE (int box_no, int i, int j, int k)
noexcept -> GpuTuple<Real>
{
Array4<Real const> const& a = ma[box_no];
return { a(i,j,k) };
});
}

/**
* @brief Computes the minimum value in a MultiFab.
*
* This function performs a parallel reduction to find the minimum value
* stored in the provided MultiFab. It uses the
* ParReduce function with a minimum reduction operation.
*
* @param multifab The MultiFab containing the values. It is assumed that
* the MultiFab is properly initialized and contains valid data.
*
* @return The minimum value found in the MultiFab.
*/
Real compute_min_of_multifab (MultiFab const& multifab)
{
auto const& ma = multifab.const_arrays();
return ParReduce(TypeList<ReduceOpMin>{}, TypeList<Real>{},
multifab, IntVect(0), // zero ghost cells
[=] AMREX_GPU_DEVICE (int box_no, int i, int j, int k)
noexcept -> GpuTuple<Real>
{
Array4<Real const> const& a = ma[box_no];
return { a(i,j,k) };
});
}

/**
* @brief Computes the maximum Inverse Mean Free Path (IMFP) for absorption and emission processes.
*