Remove strang nse (#1549)

Strang does not really allow us to do 2nd order easily because we
can't capture the evolution of the state during the burn

.github/workflows/nse_table.yml

@@ -26,26 +26,6 @@ jobs:
           sudo apt-get update -y -qq
           sudo apt-get -qq -y install curl cmake jq clang g++>=9.3.0
 
-      - name: Compile, burn_cell (NSE, aprox19)
-        run: |
-          cd unit_test/burn_cell
-          make realclean
-          make NETWORK_DIR=aprox19 USE_NSE_TABLE=TRUE INTEGRATOR_DIR=VODE -j 4
-
-      - name: Run burn_cell (NSE, aprox19)
-        run: |
-          cd unit_test/burn_cell
-          ./main3d.gnu.ex inputs_aprox19.nse amrex.fpe_trap_{invalid,zero,overflow}=1 > test.out
-
-      - name: Print backtrace
-        if: ${{ failure() && hashFiles('unit_test/burn_cell/Backtrace.0') != '' }}
-        run: cat unit_test/burn_cell/Backtrace.0
-
-      - name: Compare to stored output (NSE, aprox19)
-        run: |
-          cd unit_test/burn_cell
-          diff -I "^Initializing AMReX" -I "^AMReX" -I "^reading in reaclib rates" test.out ci-benchmarks/aprox19_nse_unit_test.out
-
       - name: Compile, burn_cell_sdc (NSE, aprox19)
         run: |
           cd unit_test/burn_cell_sdc

Make.Microphysics_extern

@@ -87,6 +87,15 @@ endif
 table:
 	@if [ ! -f helm_table.dat ]; then echo Linking helm_table.dat; ln -s $(EOS_PATH)/helm_table.dat .;  fi
 
+# USE_ALL_NSE will be used if any of the NSE techniques is applied
+ifeq ($(USE_NSE_TABLE),TRUE)
+  USE_ALL_NSE := TRUE
+endif
+
+ifeq ($(USE_NSE_NET),TRUE)
+  USE_ALL_NSE := TRUE
+endif
+
 # NSE networks need the table
 ifeq ($(USE_NSE_TABLE),TRUE)
   NSE_TABULAR_HOME ?= $(MICROPHYSICS_HOME)/nse_tabular

integration/Make.package

@@ -26,11 +26,12 @@ else
   CEXE_headers += integrator_setup_strang.H
 endif
 
-ifeq ($(USE_NSE_TABLE), TRUE)
+
+ifeq ($(USE_ALL_NSE), TRUE)
   ifeq ($(USE_ALL_SDC), TRUE)
     CEXE_headers += nse_update_sdc.H
   else
-    CEXE_headers += nse_update_strang.H
+    $(error NSE with Strang integration is not supported)
   endif
 endif
 

unit_test/test_nse_interp/GNUmakefile

@@ -11,6 +11,7 @@ USE_MPI    = FALSE
 USE_OMP    = FALSE
 
 USE_REACT = TRUE
+USE_SIMPLIFIED_SDC = TRUE
 
 EBASE = main