use multiple angle formula in sneut to speed up sin/cos #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to set these each time we enter the function
|
this will cause roundoff-level diffs |
yut23
requested changes
Oct 30, 2023
Co-authored-by: Eric T. Johnson <[email protected]>
zingale
changed the title
yut23
approved these changes
Oct 30, 2023
yut23
added a commit
to yut23/Microphysics
that referenced
this pull request
Nov 6, 2023
This reverts all the benchmark updates made in AMReX-Astro#1379, as the actual changes should be very minor.
zingale
pushed a commit
that referenced
this pull request
Nov 7, 2023
This reverts all the benchmark updates made in #1379, as the actual changes should be very minor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.