New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for bool in _parameters again, integer -> int, character -> string #1536

Merged

zingale merged 13 commits into AMReX-Astro:development from zingale:bool_c_parameters

Apr 29, 2024

Member

zingale commented Apr 29, 2024

many int parameters were changed to bool -- this will help when we go
all-in on a struct

also replace all the X.dY with C++ style

zingale added 3 commits

April 28, 2024 21:04


          allow for bool in _parameters again, integer -> int, character -> string

1a1d57d

also replace all the X.dY with C++ style


          fix parsing of bool

d48cbd5


          use true/false

8d9a556

Member Author

zingale commented Apr 29, 2024

tests pass: http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2024-04-29-001/index.html

yut23 reviewed

View reviewed changes

opacity/rad_power_law/_parameters Outdated Show resolved Hide resolved


          Update opacity/rad_power_law/_parameters

ea2988e

Co-authored-by: Eric T. Johnson <[email protected]>

yut23 reviewed

View reviewed changes

unit_test/burn_cell/_parameters Outdated Show resolved Hide resolved


          Update unit_test/burn_cell/_parameters

a737dc6

Co-authored-by: Eric T. Johnson <[email protected]>

yut23 reviewed

View reviewed changes

integration/_parameters Outdated Show resolved Hide resolved


          Update integration/_parameters

02f818f

Co-authored-by: Eric T. Johnson <[email protected]>

yut23 reviewed

View reviewed changes

unit_test/burn_cell/_parameters Outdated Show resolved Hide resolved


          Update unit_test/burn_cell/_parameters

84b8e18

Co-authored-by: Eric T. Johnson <[email protected]>

yut23 reviewed

View reviewed changes

Collaborator

yut23 left a comment

integration/BackwardEuler/_parameters and integration/QSS/_parameters need integer -> int replacements; unit_test/burn_cell_primordial_chem/_parameters needs character -> string. Looks good otherwise

EOS/gamma_law/_parameters Outdated Show resolved Hide resolved

nse_solver/_parameters Outdated Show resolved Hide resolved

nse_solver/_parameters Outdated Show resolved Hide resolved

unit_test/burn_cell/_parameters Outdated Show resolved Hide resolved

unit_test/burn_cell_sdc/_parameters Outdated Show resolved Hide resolved

zingale and others added 4 commits

April 29, 2024 14:09


          Update EOS/gamma_law/_parameters

79ece1c

Co-authored-by: Eric T. Johnson <[email protected]>


          Update nse_solver/_parameters

ec8c4aa

Co-authored-by: Eric T. Johnson <[email protected]>


          Update nse_solver/_parameters

823b844

Co-authored-by: Eric T. Johnson <[email protected]>


          some more fixes

78271a3

Member Author

zingale commented Apr 29, 2024

updated the remaining. Let's see if the tests pass...

zingale and others added 2 commits

April 29, 2024 14:25


          Update unit_test/burn_cell/_parameters

95c3f1a

Co-authored-by: Eric T. Johnson <[email protected]>


          Update unit_test/burn_cell_sdc/_parameters

Co-authored-by: Eric T. Johnson <[email protected]>

Member Author

zingale commented Apr 29, 2024

okay, I think that this is all set now

yut23 approved these changes

View reviewed changes

zingale merged commit 8e7e375 into AMReX-Astro:development

29 checks passed

zingale deleted the bool_c_parameters branch

April 29, 2024 19:44

zingale mentioned this pull request

fix .true. in _parameter files AMReX-Astro/Castro#2837

Merged

5 tasks

yut23 mentioned this pull request

create a struct to hold the Microphysics runtime parameters #1433

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet